https://bugs.kde.org/show_bug.cgi?id=504726
Nicolas Fella <nicolas.fe...@gmx.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit|https://invent.kde.org/util |https://invent.kde.org/util
|ities/kteatime/-/commit/653 |ities/kteatime/-/commit/fd6
|7191f3087ba86b7621682fe6263 |2006dfd3d62cf2137e4c0ab1c75
|0ba25cea9d |580191d938
--- Comment #3 from Nicolas Fella <nicolas.fe...@gmx.de> ---
Git commit fd62006dfd3d62cf2137e4c0ab1c75580191d938 by Nicolas Fella, on behalf
of Efe Çiftci.
Committed on 18/06/2025 at 06:58.
Pushed by nicolasfella into branch 'release/25.04'.
Fix tea remove button in settings
This commit fixes an issue where the Remove button in the Settings window
incorrectly modified entries in the tea list. When an item is removed from
`m_model`, the list of selected indices briefly becomes empty. This triggers
unintended actions, including a call to `Tea::setName()` with an empty `name`,
which causes the next entry in `m_model` to be renamed.
This MR resolves the issue by ensuring `SettingsDialog::updateSelection()` does
not alter the tea list when items exist but no indices are selected. The
current solution may not be the most elegant but is functional. Tested by
observing behavior of Add, Move, and Remove buttons.
(cherry picked from commit 6537191f3087ba86b7621682fe62630ba25cea9d)
M +3 -0 src/settings.cpp
https://invent.kde.org/utilities/kteatime/-/commit/fd62006dfd3d62cf2137e4c0ab1c75580191d938
--
You are receiving this mail because:
You are watching all bug changes.
