https://bugs.kde.org/show_bug.cgi?id=374689

Kai Uwe Broulik <k...@privat.broulik.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/pla
                   |                            |sma-workspace/f6ce91499a16c
                   |                            |d9e8fa4b56fdadf254e3ab79bd1
         Resolution|---                         |FIXED
   Version Fixed In|                            |5.9.0
             Status|CONFIRMED                   |RESOLVED

--- Comment #3 from Kai Uwe Broulik <k...@privat.broulik.de> ---
Git commit f6ce91499a16cd9e8fa4b56fdadf254e3ab79bd1 by Kai Uwe Broulik.
Committed on 08/01/2017 at 15:12.
Pushed by broulik into branch 'master'.

[Image Wallpaper] Simplify width/height management

Directly expose "targetSize" as property. The wallpaper is already initialized
with
the correct size for some time now but the fact that we had two properties
width and height
in there had it still do unneccessary work when it emitted "sizeChanged(2560,
0)" and
then the final "sizeChanged(2560, 1440)" afterwards.

Also, I didn't really see a point in storing the wallpaper size in its config,
it's overwritten by the wallpaper anyway and only used in the wallpaper config
dialog
for the aspect ratio. We can just ask the view directly then.
FIXED-IN: 5.9.0

Differential Revision: https://phabricator.kde.org/D4001

M  +3    -29   wallpapers/image/image.cpp
M  +2    -11   wallpapers/image/image.h
M  +0    -8    wallpapers/image/imagepackage/contents/config/main.xml
M  +2    -3    wallpapers/image/imagepackage/contents/ui/config.qml
M  +1    -14   wallpapers/image/imagepackage/contents/ui/main.qml
M  +0    -8    wallpapers/image/slideshowpackage/contents/config/main.xml

https://commits.kde.org/plasma-workspace/f6ce91499a16cd9e8fa4b56fdadf254e3ab79bd1

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to