https://bugs.kde.org/show_bug.cgi?id=488283

--- Comment #5 from andy <[email protected]> ---
This is annoying enough I hacked on a work-around patch, essentially needing to
ignore `.isLocalFile()` in KFileItemModelRolesUpdater::startPreviewJob() and
possibly KFileItemModelRolesUpdater::loadNextHoverSequencePreview().

I'd appreciate either a setting to always write thumbnails and ignore any
"security benefits" (I can manage on my own, especially if using containers,
bwrap, bind mounts, etc.) or better detection of acceptable "local" partitions
including allowing tmpfs home folder, allowing thumbnailing anything in bind
mounts, /mnt, or any mount points derived from permanent drives with luks
containers, ZFS, LVM, etc.

```
diff --git a/src/kitemviews/kfileitemmodelrolesupdater.cpp
b/src/kitemviews/kfileitemmodelrolesupdater.cpp
index 679370455..ffb9ac1e1 100644
--- a/src/kitemviews/kfileitemmodelrolesupdater.cpp
+++ b/src/kitemviews/kfileitemmodelrolesupdater.cpp
@@ -984,7 +984,7 @@ void KFileItemModelRolesUpdater::startPreviewJob()

     KIO::PreviewJob *job = new KIO::PreviewJob(items, cacheSize(),
&m_enabledPlugins);
     job->setDevicePixelRatio(m_devicePixelRatio);
-    job->setIgnoreMaximumSize(referenceItem.isLocalFile() &&
!referenceItem.isSlow() && m_localFileSizePreviewLimit <= 0);
+    job->setIgnoreMaximumSize(!referenceItem.isSlow() &&
m_localFileSizePreviewLimit <= 0);
     if (job->uiDelegate()) {
         KJobWidgets::setWindow(job, qApp->activeWindow());
     }
@@ -1093,7 +1093,7 @@ void
KFileItemModelRolesUpdater::loadNextHoverSequencePreview()
     KIO::PreviewJob *job = new KIO::PreviewJob({m_hoverSequenceItem},
cacheSize(), &m_enabledPlugins);

     job->setSequenceIndex(loadSeqIdx);
-    job->setIgnoreMaximumSize(m_hoverSequenceItem.isLocalFile() &&
!m_hoverSequenceItem.isSlow() && m_localFileSizePreviewLimit <= 0);
+    job->setIgnoreMaximumSize(!m_hoverSequenceItem.isSlow() &&
m_localFileSizePreviewLimit <= 0);
     if (job->uiDelegate()) {
         KJobWidgets::setWindow(job, qApp->activeWindow());
     }
```

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to