https://bugs.kde.org/show_bug.cgi?id=504869

Méven <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |https://invent.kde.org/util
                   |                            |ities/ark/-/commit/7e3d11a4
                   |                            |4b4873083ed3093cca164f268f4
                   |                            |985cf

--- Comment #5 from Méven <[email protected]> ---
Git commit 7e3d11a44b4873083ed3093cca164f268f4985cf by Méven Car, on behalf of
Rafał Lichwała.
Committed on 03/02/2026 at 14:30.
Pushed by meven into branch 'master'.

extractiondialog: do not overwrite directory when extract

When we extract archive which contains single folder as top level entry
this action does not check if that folder already exists at destination
and simply overwrites its content.

This is completly unexpected and dangerous because may create mixed up
directory
contents which would be hard to restore. This action does not even warn user
that such target directory exists and contents will be combined.

This affects actions triggered by regular "Extract Dialog" (when archive
is open on double-click) and context menu "Extract Here" action
(when right-click on archive in a folder).

This commit corrects this behavior in both places:

1. In "Extract Dialog" now there is the same warning message
as it already appears when extracting to existing subfolder

2. In "Extract Here" (batch-mode and context menu) action when existing
folder is detected it creates a new one (with common 'suggestName' mechanism)
and extracts content there - intentionally creating a nested folder in such a
case.

M  +1    -0    app/batchextract.cpp
M  +12   -4    kerfuffle/extractiondialog.cpp
M  +5    -0    kerfuffle/extractiondialog.h
M  +15   -5    kerfuffle/jobs.cpp
M  +1    -0    part/part.cpp

https://invent.kde.org/utilities/ark/-/commit/7e3d11a44b4873083ed3093cca164f268f4985cf

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to