https://bugs.kde.org/show_bug.cgi?id=508465

Filip Fila <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #15 from Filip Fila <[email protected]> ---
The new highlights look better and I do understand wanting to improve looks.
But bypassing kstyle to hardcode Breeze visuals directly in a core KDE app is
not the right approach.

It would be acceptable if the underlying code was modified and that it required
adaptations that other styles then needed to implement. But this hardcodes the
appearance in a way that other styles like Oxygen simply can't override.

Option 1 from comment #10 is the right approach. Yes, it carries some risk of
breakage, but that's a solvable problem and exactly the kind of thing that
belongs in a style. Hardcoding visual behavior in application code because it's
easier than fixing it in the right place is how we end up with theming that's
increasingly Breeze-locked in practice.

I'd be happy to help test any changes made through the kstyle path if that's
useful.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to