https://bugs.kde.org/show_bug.cgi?id=514297
--- Comment #32 from [email protected] --- > (In reply to Mark Wielaard from comment #25) > > > OK, nice, so when is_guarded is called, we do a sanity check that our > > internal data (still) matches the /proc/self/pagemap guard bit. > > I think that can/should be extended to also trigger for when > > AM_SANITY_CHECK/am_do_sync_check is called. > > Probably added to parse_procselfmaps and/or the sync_check_mapping_callback. > > So each segment is checked > > for matching /proc/self/maps and then for each segment to check whether or > > not it contains guard pages according > > to /proc/self/pagemap. But this might be a lot of extra work. Would still be > > useful to catch issues though. > > Oh, I've forgot to address this one. Let me focus on this now! I've added such cross check and it seems to test fine locally: https://sourceware.org/git/?p=valgrind.git;a=commitdiff;h=241531e7184ebf6d52389140d417b700c55f61e7 With this, the existing review points were addressed. I would appreciate a review pretty please. -- You are receiving this mail because: You are watching all bug changes.
