https://bugs.kde.org/show_bug.cgi?id=271615

--- Comment #14 from [email protected] ---
Created attachment 192414
  --> https://bugs.kde.org/attachment.cgi?id=192414&action=edit
updated patch

Good morning Mark,  I've updated the commit message, reordered NEWS, removed
the TODO for instruction support detection since, as you say, its generic, sw
emulated.  Updated the if statement.

> We'll just update the cpuid to 8 indicate we do support POPCNT.
I've added that to the VEX/priv/guest_x86_helpers.c --->
x86g_dirtyhelper_CPUID_sse3()

This is based on Intel manual https://cdrdv2.intel.com/v1/dl/getContent/671110
--> page 1112, which reads: "#UD  If CPUID.01H:ECX.POPCNT[23] = 0" for all the
CPU modes.

I did this because it was easy and it proves that I'm getting the cpuid feature
advertising right. But I suspect the correct solution is slightly more complex
- it is to create a new dirtyhelper for sse4 and move the feature there,
because POPCNT belongs to  sse4.2.  Can you confirm, please?

For the testcase, I've kept randULong() in place, because the unsigned long
type is 32 bits wide on 32 bit intel arch, so it seems correct to me.  Can you
confirm, please?

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to