https://bugs.kde.org/show_bug.cgi?id=491898

Marco Martin <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/fram
                   |                            |eworks/kwallet/-/commit/96f
                   |                            |d747ec3d4aa30b0cbd60ed07cc9
                   |                            |115c3221a1
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #13 from Marco Martin <[email protected]> ---
Git commit 96fd747ec3d4aa30b0cbd60ed07cc9115c3221a1 by Marco Martin, on behalf
of John Keeler.
Committed on 14/07/2026 at 11:44.
Pushed by mart into branch 'master'.

kwallet-query: persist writes to new entries

writeValue() picked the write method from the entry's *existing* type.
entryType() returns Wallet::Unknown for an entry that does not exist yet,
so for a brand-new entry neither the Wallet::Password nor the Wallet::Map
branch ran: no write was issued and the tool still called quit() and
exited 0. Creating a new secret with `kwallet-query -w` therefore silently
did nothing, while overwriting an already-existing entry worked. A direct
org.kde.kwalletd6 writePassword() D-Bus call persists correctly because it
has no such type gate.

Default a new (Unknown) entry to a Password write, matching writePassword().
While here, fail with a non-zero exit instead of reporting a phantom
success when the entry is an unwritable pre-existing type or the map input
is invalid JSON, and create the target folder on demand rather than
dropping the write when the folder does not exist yet.

M  +35   -16   src/runtime/kwallet-query/src/querydriver.cpp

https://invent.kde.org/frameworks/kwallet/-/commit/96fd747ec3d4aa30b0cbd60ed07cc9115c3221a1

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to