https://bugs.kde.org/show_bug.cgi?id=510976

nyanpasu64 <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #1 from nyanpasu64 <[email protected]> ---
I ran into this issue as well.

- Reading the source code
(https://github.com/KDE/kio/blob/master/src/kioworkers/ftp/ftp.cpp), I found
that kio actually prefers to send `list -la`, then `list`, and finally `LIST
-la` (never LIST by itself). I'm not sure why it prefers lowercase.
- It never implemented MLS* because the code seems to date back from the early
2000s, and MLSD only came out in 2007.
- The `list` parsing code is... scary. A comment says that `ls` outputs a time
of day instead of year, when a file "is between than 6 months... old and 1 hour
in the future."
  - As a result, if the server's date is wrong, it can treat files from the
*wrong time* as the current year, causing the client to display an entirely
incorrect year for the file!

I agree KIO should implement MLST/D, but the file reads like a relic of the
past, with comments referencing files from 1997 to 2004. Interestingly ftp.c
*is* receiving commits up to the present, with a mixture of adapting the code
to broader KIO changes and *FTP-specific updates* that never patched this
corner of the implementation! I wonder if this is something a LLM could cook up
(since I'm busy working on a homebrew FTP *server*)... though I suspect KDE
wouldn't merge code I'm not putting my full attention to, to understand well
enough to check its work.

I ran into *another* issue: When the server restarts and KIO reconnects,
Dolphin fails to send its working directory, then tries to list files in the
current folder (but the server returns a listing from the root):

    // Don't use the path in the list command:
    // We changed into this directory anyway - so it's enough just to send
"list".

I think this should be reported separately. Do I need to start learning the
code of kio_ftp? (I also ran into Bug 503928, possibly related to Bug 512354.)

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to