https://bugs.kde.org/show_bug.cgi?id=301048
--- Comment #4 from caulier.gil...@gmail.com --- Ahmed, Patch do not compile : /home/gilles/Devel/5.x/core/utilities/queuemanager/tools/decorate/watermark.cpp: In constructor ‘Digikam::WaterMark::Private::Private()’: /home/gilles/Devel/5.x/core/utilities/queuemanager/tools/decorate/watermark.cpp:127:22: warning: ‘Digikam::WaterMark::Private::useTextRadioButton’ will be initialized after [-Wreorder] QRadioButton* useTextRadioButton; ^ /home/gilles/Devel/5.x/core/utilities/queuemanager/tools/decorate/watermark.cpp:124:22: warning: ‘QCheckBox* Digikam::WaterMark::Private::useBackgroundCheckBox’ [-Wreorder] QCheckBox* useBackgroundCheckBox; ^ /home/gilles/Devel/5.x/core/utilities/queuemanager/tools/decorate/watermark.cpp:89:5: warning: when initialized here [-Wreorder] Private() : ^ /home/gilles/Devel/5.x/core/utilities/queuemanager/tools/decorate/watermark.cpp:133:22: warning: ‘Digikam::WaterMark::Private::placementPositionComboBox’ will be initialized after [-Wreorder] QComboBox* placementPositionComboBox; ^ /home/gilles/Devel/5.x/core/utilities/queuemanager/tools/decorate/watermark.cpp:132:22: warning: ‘QComboBox* Digikam::WaterMark::Private::placementTypeComboBox’ [-Wreorder] QComboBox* placementTypeComboBox; ^ /home/gilles/Devel/5.x/core/utilities/queuemanager/tools/decorate/watermark.cpp:89:5: warning: when initialized here [-Wreorder] Private() : ^ /home/gilles/Devel/5.x/core/utilities/queuemanager/tools/decorate/watermark.cpp:135:22: warning: ‘Digikam::WaterMark::Private::sparsityFactorSpinBox’ will be initialized after [-Wreorder] QDoubleSpinBox * sparsityFactorSpinBox; ^ /home/gilles/Devel/5.x/core/utilities/queuemanager/tools/decorate/watermark.cpp:134:22: warning: ‘QComboBox* Digikam::WaterMark::Private::rotationComboBox’ [-Wreorder] QComboBox* rotationComboBox; ^ /home/gilles/Devel/5.x/core/utilities/queuemanager/tools/decorate/watermark.cpp:89:5: warning: when initialized here [-Wreorder] Private() : ^ In file included from /usr/lib64/qt5/include/QtGui/qfont.h:38:0, from /usr/lib64/qt5/include/QtGui/QFont:1, from /home/gilles/Devel/5.x/core/utilities/queuemanager/tools/decorate/watermark.h:31, from /home/gilles/Devel/5.x/core/utilities/queuemanager/tools/decorate/watermark.cpp:26: /usr/lib64/qt5/include/QtCore/qstring.h: In member function ‘virtual void Digikam::WaterMark::registerSettingsWidget()’: /usr/lib64/qt5/include/QtCore/qstring.h:788:5: error: ‘QString::QString(const char*)’ is private QString(const char *ch); ^ /home/gilles/Devel/5.x/core/utilities/queuemanager/tools/decorate/watermark.cpp:322:177: error: within this context d->denseRepetitionCheckBox->setWhatsThis("When you choose to have the watermark repeated many times in the placement combo box, you can specify here whether the repetition"); ^ In file included from /usr/lib64/qt5/include/QtGui/qfont.h:38:0, from /usr/lib64/qt5/include/QtGui/QFont:1, from /home/gilles/Devel/5.x/core/utilities/queuemanager/tools/decorate/watermark.h:31, from /home/gilles/Devel/5.x/core/utilities/queuemanager/tools/decorate/watermark.cpp:26: /usr/lib64/qt5/include/QtCore/qstring.h:788:5: error: ‘QString::QString(const char*)’ is private QString(const char *ch); ^ /home/gilles/Devel/5.x/core/utilities/queuemanager/tools/decorate/watermark.cpp:336:126: error: within this context "you can check this to make the watermark rotations random also[0,90,180,270]"); ^ In file included from /usr/lib64/qt5/include/QtGui/qfont.h:38:0, from /usr/lib64/qt5/include/QtGui/QFont:1, from /home/gilles/Devel/5.x/core/utilities/queuemanager/tools/decorate/watermark.h:31, from /home/gilles/Devel/5.x/core/utilities/queuemanager/tools/decorate/watermark.cpp:26: /usr/lib64/qt5/include/QtCore/qstring.h:788:5: error: ‘QString::QString(const char*)’ is private QString(const char *ch); ^ /home/gilles/Devel/5.x/core/utilities/queuemanager/tools/decorate/watermark.cpp:356:103: error: within this context " typically between 1.0 and 3.0. can also be less than 1.0"); ^ core/utilities/queuemanager/CMakeFiles/queuemanager_src.dir/build.make:518: recipe for target 'core/utilities/queuemanager/CMakeFiles/queuemanager_src.dir/tools/decorate/watermark.cpp.o' failed make[2]: *** [core/utilities/queuemanager/CMakeFiles/queuemanager_src.dir/tools/decorate/watermark.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs.... ----- In source code i18n(" ") must be replaced by QLatin1String(" ") Fix also indentation and alignment (coding style). I suspect also a broken braken in last function. Did you compile this code on your computer ? Gilles Caulier -- You are receiving this mail because: You are watching all bug changes.