https://bugs.kde.org/show_bug.cgi?id=523843

--- Comment #6 from Mark Wielaard <[email protected]> ---
I guess -mstackrealign globally would help to make sure that if  doHelperCall
calls a (dirty) helper function with 4 instead of 16-byte stack alignment works
because every function would realign the stack itself.

But I was kind of hoping we could fix doHelperCall to keep the stack 16-byte
aligned. But that might be difficult since it is somewhat tricky code that also
seems to be adjust the stack for different types it needs to put there.

Just adding "-mstack-alignment=16 -mstackrealign" to the x86 build might be OK
if it doesn't impact performance too much.
It looks like all it does is add a push   %ebp; mov    %esp,%ebp;  
$0xfffffff0,%esp to the prologue. A then an extra lea    -0xc(%ebp),%esp; pop
%ebp; to epilogue. So it might indeed not really impact performance (assuming
small functions get inlined).

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to