https://bugs.kde.org/show_bug.cgi?id=521413
--- Comment #13 from Mark Wielaard <[email protected]> --- (In reply to Martin Cermak from comment #12) > Created attachment 195673 [details] > proposed patch OK, this adds dis_PCMPISTRI_3A_x86() to cover the special case commented out in the previous variant. - Fixes comment in VexGuestLayout. - dis_PCMPISTRI_3A_x86() guest_x86_toIR.c (based on dis_PCMPISTRI_3A in guest_amd64_toIR.c) The FIXME comment should reference RegNoL == 8 (not 16), which is the pseudo register on x86. I am not sure if the FIXME still needs to be fixed, I think it is OK, but there is no testcase. Instead of using Iop_GetMSBs8x16 (which isn't there for x86) split and use Iop_GetMSBs8x8. Comment /* And thats our rcx. */ is really for ecx (correct in the code and also for the 64bit variant which actually uses just the 32bit ecx). Shouldn't IRTemp cc = newTemp(Ity_I64); be a Ity_I32? - dis_PCMPxSTRx32 drops isAvx, fixes pseudo-register name in comments and uses dis_PCMPISTRI_3A_x86 fir the special 0x3A case (if STRI operation). - It drops the none/tests/x86/pcmpxstrx32 testcase? -- You are receiving this mail because: You are watching all bug changes.
