https://bugs.kde.org/show_bug.cgi?id=379116
Harald Sitter <sit...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://commits.kde.org/ki1
| |8n/7bce4e8128365de13682b400
| |e4acf5b393e94ab9
Status|UNCONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #6 from Harald Sitter <sit...@kde.org> ---
Git commit 7bce4e8128365de13682b400e4acf5b393e94ab9 by Harald Sitter.
Committed on 25/04/2017 at 08:30.
Pushed by sitter into branch 'master'.
fix basename handling of po files
Summary:
get_filename_component(... ... NAME_WE) gets the name without the *longest*
extension. in case of 'org.kde.plasma.kittens.po' that would leave us
with 'org' as name. Use a regular expression to grab the basename without
the short extension (e.g. 'org.kde.plasma.kittens') to prevent broken file
names.
add a test to assert that this works in the future
Reviewers: apol, ilic
Reviewed By: apol
Subscribers: #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D5557
M +13 -0 autotests/CMakeLists.txt
A +6 -0 autotests/ki18n_install/CMakeLists.txt
A +20 -0
autotests/ki18n_install/po/de/plasma_applet_org.kde.plasma.katesessions.po
A +5 -0 autotests/ki18n_install/test.cmake
M +6 -1 cmake/build-pofiles.cmake
https://commits.kde.org/ki18n/7bce4e8128365de13682b400e4acf5b393e94ab9
--
You are receiving this mail because:
You are watching all bug changes.
