https://bugs.kde.org/show_bug.cgi?id=378452

Martin Flöser <mgraess...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|REOPENED                    |RESOLVED
      Latest Commit|                            |https://commits.kde.org/kwi
                   |                            |n/229be65e4002987e2de0113ef
                   |                            |9b7140492d2d681

--- Comment #21 from Martin Flöser <mgraess...@kde.org> ---
Git commit 229be65e4002987e2de0113ef9b7140492d2d681 by Martin Flöser, on behalf
of Martin Gräßlin.
Committed on 12/05/2017 at 05:06.
Pushed by graesslin into branch 'Plasma/5.9'.

Improve the escape key handling for breaking constrained pointers

Summary:
So far KWin started to filter out the escape key as soon as it gets
pressed. This was done by unsetting keyboard focus. The idea was to
reset keyboard focus when it is only a short press and that then the
keyboard state is correct for the application. But in practice this
does not work. The only application currently supporting pointer
constraints (Xwayland) does not do anything on a key which is pressed
when gaining keyboard focus. The result is escape not working in
pointer constrained Xwayland windows.

This change addresses this problem by changing the interaction to only
unset keyboard focus when our break constraints condition is met. This
should also result in the application not handling the key release, but
it means it gets the key press. Unfortunately I don't have a good way
to test.

Test Plan: None

Reviewers: #kwin, #plasma

Subscribers: plasma-devel, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D5488

M  +3    -2    autotests/integration/pointer_constraints_test.cpp
M  +5    -3    input.cpp
M  +1    -1    keyboard_input.cpp

https://commits.kde.org/kwin/229be65e4002987e2de0113ef9b7140492d2d681

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to