https://bugs.kde.org/show_bug.cgi?id=368529
Ivo Raisr <iv...@ivosh.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |ASSIGNED
--- Comment #7 from Ivo Raisr <iv...@ivosh.net> ---
I am a little worried about this condition in the patch:
#if defined(ANDROID) && defined(__clang__)
Nowhere in Valgrind sources we currently base a decision on naked "ANDROID".
It is always this combo (from vki-linux.h):
#if defined(VGPV_arm_linux_android) || defined(VGPV_x86_linux_android) \
|| defined(VGPV_mips32_linux_android) \
|| defined(VGPV_arm64_linux_android)
...
#endif /* defined(VGPV_*_linux_android) */
If this patch is really arm-android specific, then it should fold inside
existing
#if defined(VGP_arm_linux) [at line 2424]
...
#endif [at line 2442]
with a guard such as:
#if defined(VGPV_arm_linux_android)
...
#endif
No need to "defined(__clang__)".
Let me know what is the case here.
Please eventually modify the patch and test it on arm.
--
You are receiving this mail because:
You are watching all bug changes.
