https://bugs.kde.org/show_bug.cgi?id=372635
Aleix Pol <aleix...@kde.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleix...@kde.org --- Comment #20 from Aleix Pol <aleix...@kde.org> --- (In reply to Aetf from comment #17) > Git commit a41a850a3943dbc1bd43b867def775e41902f987 by Peifeng Yu. > Committed on 30/04/2017 at 18:20. > Pushed by peifengyu into branch 'master'. > > Only follow mouse when moved (Fixes Bug #372635) > > Summary: > Use a new variable moved to detect if mouse moved and only change index if > the mouse moved. This helps preventing index changes when only using > keyboard to search something in milou and to not accidently start/open > something you did not want (see bug report > https://bugs.kde.org/show_bug.cgi?id=372635 ) > > In general the onEntered signal seems to be broken in Qt somehow as I could > not make it work reliably with Qt 5.7.1. Sometimes it worked but mostly the > code using onEntered failed to work with onPositionChanged (I guess this > also does not always set it to true). > Hence I tried containsMouse which seems to work reliably at least on Qt > 5.7.1. > Tests are appreciated especially on other Qt versions. > > Reviewers: broulik, davidedmundson > > Reviewed By: davidedmundson > > Subscribers: ltoscano, qi437103, lfurmetz, anthonyfieroni, davidedmundson, > plasma-devel > > Tags: #plasma > > Differential Revision: https://phabricator.kde.org/D5490 > > M +1 -0 lib/CMakeLists.txt > A +40 -0 lib/mousehelper.cpp [License: GPL (v2/3)] > A +44 -0 lib/mousehelper.h [License: GPL (v2/3)] > M +12 -4 lib/qml/ResultDelegate.qml > M +9 -0 lib/qml/ResultsView.qml > M +5 -0 lib/qml/qmlplugins.cpp > > https://commits.kde.org/milou/a41a850a3943dbc1bd43b867def775e41902f987 Thanks a lot for fixing it Aetf! :D -- You are receiving this mail because: You are watching all bug changes.