https://bugs.kde.org/show_bug.cgi?id=381105
--- Comment #38 from David Edmundson <k...@davidedmundson.co.uk> --- Git commit a44d84ef47492ca60ee608996b5ab1f2849ef16e by David Edmundson. Committed on 14/08/2017 at 09:06. Pushed by davidedmundson into branch 'Plasma/5.10'. Don't change fillMode of image just before deleting it It is still set for when a source is applied for the next transistion. Summary: This saves evaluating a new paintedSize and doing a bunch of evaluations which are not used. More importantly it works round a Qt animation crash. fadeAnim.running is bound to otherImage.status !== loading with the intention of delaying animations until the images are really loaded. By setting the fill mode and then the source, we go to loading and back, effectively restarting the animation from within the animation. This leads to a crash. Test Plan: End user result is the same. Reviewers: #plasma, broulik, mart Reviewed By: #plasma, broulik, mart Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D7248 M +1 -1 wallpapers/image/imagepackage/contents/ui/main.qml https://commits.kde.org/plasma-workspace/a44d84ef47492ca60ee608996b5ab1f2849ef16e -- You are receiving this mail because: You are watching all bug changes.
