https://bugs.kde.org/show_bug.cgi?id=347351
Kevin Funk <kf...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |http://commits.kde.org/kdev
| |platform/2df0558b458dae4694
| |73e117ad6045a29802359a
Status|REOPENED |RESOLVED
Version Fixed In| |5.0
Resolution|--- |FIXED
--- Comment #3 from Kevin Funk <kf...@kde.org> ---
Git commit 2df0558b458dae469473e117ad6045a29802359a by Kevin Funk, on behalf of
Artur Puzio.
Committed on 02/02/2016 at 23:21.
Pushed by kfunk into branch '5.0'.
Git: Display dialog to configure user & name
Summary:
Added function to get git config
Added checking of `user.email` and `user.name` when committing
Added possibility to configure global git parameters
Added `QDialog` extension to choose the name and email, with possibility to
save the settings as global and validation.
Used the extension to handle the lack of `user.name` or `user.email` configured
when committing.
Added unit tests for readConfigOption and setConfigOption.
This fixes the [[ https://bugs.kde.org/show_bug.cgi?id=347351 | Bug 347351 ]]
Test Plan:
The new dialog works fine.
Tests pass.
FIXED-IN: 5.0
Reviewers: kfunk
Reviewed By: kfunk
Subscribers: mwolff, kdevelop-devel
Differential Revision: https://phabricator.kde.org/D852
M +2 -0 plugins/git/CMakeLists.txt
A +82 -0 plugins/git/gitnameemaildialog.cpp [License: LGPL (v2+)]
A +54 -0 plugins/git/gitnameemaildialog.h [License: LGPL (v2+)]
A +145 -0 plugins/git/gitnameemaildialog.ui
M +33 -3 plugins/git/gitplugin.cpp
M +2 -1 plugins/git/gitplugin.h
M +2 -0 plugins/git/tests/CMakeLists.txt
M +29 -0 plugins/git/tests/test_git.cpp
M +1 -0 plugins/git/tests/test_git.h
http://commits.kde.org/kdevplatform/2df0558b458dae469473e117ad6045a29802359a
--
You are receiving this mail because:
You are watching all bug changes.
