https://bugs.kde.org/show_bug.cgi?id=385463
Fabian Vogt <fab...@ritter-vogt.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/pla
| |sma-desktop/06f01ed291ca210
| |57497fd0ceaa69f6e4d324bc3
--- Comment #3 from Fabian Vogt <fab...@ritter-vogt.de> ---
Git commit 06f01ed291ca21057497fd0ceaa69f6e4d324bc3 by Fabian Vogt.
Committed on 10/10/2017 at 16:53.
Pushed by fvogt into branch 'Plasma/5.11'.
Fix editing items in SimpleFavoritesModel
Summary:
tools.js is supposed to support both KaStatsFavoritesModel (used for
favorite applications) and SimpleFavoritesModel (used for system actions,
like poweroff/reboot/logout). The latter did not work though, as tools.js
unconditionally calls methods only present in KaStatsFavoritesModel.
This commit makes KaStatsFavoritesModel API compatible to SimpleFavoritesModel
and changes the relevant code in tools.js to support both.
Additionally, this syncs applets/kickoff/package/contents/code/tools.js again.
Test Plan:
Before this patch it wasn't possible to remove system actions from
the favorites bar.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: hein, davidedmundson, rikmills, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8178
M +6 -6 applets/kicker/package/contents/code/tools.js
M +2 -2 applets/kicker/plugin/kastatsfavoritesmodel.cpp
M +13 -11 applets/kickoff/package/contents/code/tools.js
https://commits.kde.org/plasma-desktop/06f01ed291ca21057497fd0ceaa69f6e4d324bc3
--
You are receiving this mail because:
You are watching all bug changes.
