https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #12 from Andreas Arnez <ar...@linux.vnet.ibm.com> --- (In reply to Vadim Barkov from comment #10) > Created attachment 108579 [details] > Initial vector support (chapter 21) (remastered) > > Changes: > - Removed ALL trailing whitespaces changes (patch size decreased in five > times) > - Removed some __inline__ 's from guest_s390_toIR.c > - Rearranged code in sequence of commits (patches) to make the review > process easier Yeah, that looks much better. Good work! A few comments: * In /none/tests/s390x/vector.c, you use z13 instructions in __asm__ directives. This is probably OK if you make sure that this test is executed only on systems that support this. See, for instance how this is done for AVX using the build-time variable BUILD_AVX_TESTS defined in configure.ac. * When running auxprogs/s390-check-opcodes.pl with the appropriate parameters, I get some warnings. It would be nice if you could get rid of them. -- You are receiving this mail because: You are watching all bug changes.
