https://bugs.kde.org/show_bug.cgi?id=372114
Martin Flöser <mgraess...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://commits.kde.org/kwi
| |n/a7117e430454f8e39b1279695
| |ff83bf73e1eb9ed
Status|UNCONFIRMED |RESOLVED
Version Fixed In| |5.11.3
Resolution|--- |FIXED
--- Comment #39 from Martin Flöser <mgraess...@kde.org> ---
Git commit a7117e430454f8e39b1279695ff83bf73e1eb9ed by Martin Flöser.
Committed on 05/11/2017 at 09:25.
Pushed by graesslin into branch 'Plasma/5.11'.
Don't use the global KConfig object on the OpenGL freeze detection thread
Summary:
This is meant to address Bug 372114. The problem here is that the KConfig
object (and its derivatives), that the freeze detection thread needs to
record the freeze, are not thread safe. When it happens that the main
thread is in fact not frozen, it is possible that the two stomp on each
other's KConfig object.
The solution applied here is to use the KSharedConfig::openConfig
function, which is thread safe, on the freeze detection thread. As was
mentioned by Martin Flöser in the discussion, the thread needs to obey
the name of the main config file of KWin, which can change in the future.
As a secondary issue, this patch also turns off KCrash reporting for
aborts due to a freeze being detected. IMO it is not very user friendly
to still show a crash report to the user, even after this bug is fixed,
for the deliberate SIGABRT. Maybe a less intrusive notification could be
used to tell the user why effects are suddenly disabled?
I've been using kwin with this change for several weeks now and it makes
the restarts of kwin due to freezes unobtrusive. However, most (I would
say almost all) of these freezes are actually instances where the system
is being slow after eg. screen resolution is changed.
FIXED-IN: 5.11.3
Reviewers: #kwin, graesslin
Reviewed By: #kwin, graesslin
Subscribers: ngraham, graesslin, anthonyfieroni, cfeck, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D8356
M +1 -1 plugins/platforms/x11/standalone/CMakeLists.txt
M +5 -2 plugins/platforms/x11/standalone/x11_platform.cpp
https://commits.kde.org/kwin/a7117e430454f8e39b1279695ff83bf73e1eb9ed
--
You are receiving this mail because:
You are watching all bug changes.
