https://bugs.kde.org/show_bug.cgi?id=385356
Mauro Carvalho Chehab <mchehab+...@kernel.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|REOPENED |RESOLVED
--- Comment #6 from Mauro Carvalho Chehab <mchehab+...@kernel.org> ---
(In reply to Mauro Carvalho Chehab from comment #5)
> (In reply to Heikki Kantola from comment #4)
> > The patches seem to work pretty well, but there is one minor detail that
> > bugs me: when you select a program from EPG for recording, Kaffeine still
> > picks the title in the first available language rather than in the one you
> > have selected.
>
> Yeah, also at OSD it won't honor the selected language.
>
> In the case of EPG recording, it only uses the first language internally, as
> it simplifies the logic. It shouldn't be hard to display a different
> language, but it sounds counter-intuitive to set a global language
> preference at the "Program Guide" window, but moving it to the TV Setting
> windows (where such kind of global preferences belong) would be weird, as
> this is the kind of window that it is set before TV scan. On that time,
> Kaffeine still doesn't know what languages are actually present at the
> received streams.
>
> I could perhaps write a table of ISO 639-2 codes and use such table to setup
> the language default, allowing the user to select any existing language code
> there, but I guess qt5 doesn't have a library that I could use, and having
> to maintain such table inside Kaffeine could be painful as times goes by.
>
> Do you have any other suggestions?
After sleeping on it, I decided to keep the language dialog at the Program
Guide. After all, it is all related to EPG parsing.
Now, if a language is selected via the Program guide, it will use it also for
OSD.
In the specific case of recording, it will use the language that was used when
a program is selected to be recorded. So, if, for instance, a program was
originally scheduled to be recorded when the Program Guide is in Finish, it
will show it in Finish at the recording display, even if the language was
switched later to some other language.
I also made the language more persistent, in the sense that, if you close and
re-open the EPG guide, it will use the latest value. The EPG language is not
saved, though, so if you close and re-open Kaffeine, it will reset to "Any
language".
It shouldn't be hard to save its value as well, but, on such case, it shoudn't
be just an EPG program display option, but something to be set via the TV
configuration panel. Considering the usecase of someone with multiple DVB-S
dishes, I don't think that a single option among languages should be recorded,
as different satellites may have different sets of EPG languages.
So, for now, let's not save the language definition.
--
You are receiving this mail because:
You are watching all bug changes.
