https://bugs.kde.org/show_bug.cgi?id=386421

Milian Wolff <m...@milianw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/kde
                   |                            |velop/015141e38b795b6c8ff9f
                   |                            |e616e87cf0a55065406
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED

--- Comment #14 from Milian Wolff <m...@milianw.de> ---
Git commit 015141e38b795b6c8ff9fe616e87cf0a55065406 by Milian Wolff.
Committed on 18/11/2017 at 18:07.
Pushed by mwolff into branch '5.2'.

kdev-clang: Offer all include paths for code completion

We used to only offer code completion of project paths for local
code completion in `#include "..."` contexts. And for vice versa,
we only offered system paths for global code completion in
`#include <...>` contexts. This is wrong, as the include style
only changes the order in which a compiler iterates through these
paths to find an include file. For code completion purposes, this
is not important.

Now we offer code completion in both path lists always. To show the
user the right file/dir being included, we don't sort and unify the
search path list anymore as that potentially changes the final result.
Rather, we use a hash set to ensure we don't encounter paths multiple
times and iterate over the search path lists in their original order.

M  +18   -9    plugins/clang/codecompletion/includepathcompletioncontext.cpp
M  +1    -1    plugins/clang/tests/test_codecompletion.cpp

https://commits.kde.org/kdevelop/015141e38b795b6c8ff9fe616e87cf0a55065406

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to