https://bugs.kde.org/show_bug.cgi?id=378786

Nate Graham <pointedst...@zoho.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |https://commits.kde.org/dol
                   |                            |phin/5bee1889e1682f1e7ffe55
                   |                            |e49beaf4544eaf7157
         Resolution|---                         |FIXED

--- Comment #5 from Nate Graham <pointedst...@zoho.com> ---
Git commit 5bee1889e1682f1e7ffe55e49beaf4544eaf7157 by Nathaniel Graham, on
behalf of Andreas Krutzler.
Committed on 19/11/2017 at 03:36.
Pushed by ngraham into branch 'master'.

Fix scrolling during inline renaming causes rename of wrong file

Summary:
Scrolling during inline renaming accepts the renaming now, like if one would
hit Return for example. I chose this approach because it seems the easiest way
to fix this.
This also fixes the “possible” Ui glitch where the renaming KTextField doesn’t
move along with the list item. Possible glitch, because I don’t know if this is
intentional, but for me it looks broken.
Fixes T7443

Test Plan:
* Enable "Rename inline" in dolphin settings
* Go to a folder where you have to scroll through items (many files, big
zoom,…)
* Start to rename a file (context menu, F2, …)
* Scroll with mouse wheel
* Rename  accepted -> file is renamed

Reviewers: ngraham, rkflx, #dolphin, elvisangelaccio

Reviewed By: ngraham, rkflx, #dolphin, elvisangelaccio

Subscribers: anthonyfieroni, elvisangelaccio, #dolphin

Maniphest Tasks: T7443

Differential Revision: https://phabricator.kde.org/D8822

M  +7    -3    src/kitemviews/kitemlistview.cpp
M  +7    -0    src/kitemviews/kstandarditemlistwidget.cpp
M  +3    -0    src/kitemviews/kstandarditemlistwidget.h

https://commits.kde.org/dolphin/5bee1889e1682f1e7ffe55e49beaf4544eaf7157

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to