https://bugs.kde.org/show_bug.cgi?id=386911
Kevin Funk <kf...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://commits.kde.org/kde
| |velop/f4363a0863414e46fd6d9
| |1c5690ce6aec39c587f
Version Fixed In| |5.2.1
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
--- Comment #8 from Kevin Funk <kf...@kde.org> ---
Git commit f4363a0863414e46fd6d91c5690ce6aec39c587f by Kevin Funk, on behalf of
René J.V. Bertin.
Committed on 22/11/2017 at 21:01.
Pushed by kfunk into branch '5.2'.
kdevelop: prevent empty dockwidget context menuitems
Summary:
This patch prevents dock widgets (toolviews) from having empty items in their
context menus. Most the corresponding actions can probably not be represented
in menus anyway and are thus unlikely to do anything when triggered through a
menu. The average user doesn't know that though.
The patch achieves this by filtering out QActions that would not have a title
in `IdealDockWidget::contextMenuRequested()` but also adds a menu item text to
two actions which I think make sense to include in the context menu. (Doing
this makes it possible to hide the toolview's toolbar in more situations,
gaining a bit of vertical space.)
FIXED-IN: 5.2.1
Test Plan:
Works as intended on Mac and Linux/X11 .
I understand there may be another way to detect QActions that cannot be
represented in menus but haven't yet found such an alternative. Such an
alternative could be used in addition to the empty text check which I think
should be done as argued in the summary.
Individual plugins can also override `IToolViewFactor::contextMenuActions()`.
Reviewers: kfunk
Reviewed By: kfunk
Subscribers: kdevelop-devel
Tags: #kdevelop
Differential Revision: https://phabricator.kde.org/D8954
M +8 -1 kdevplatform/sublime/idealdockwidget.cpp
M +3 -0 plugins/contextbrowser/contextbrowserview.cpp
M +2 -0 plugins/outlineview/outlinewidget.cpp
https://commits.kde.org/kdevelop/f4363a0863414e46fd6d91c5690ce6aec39c587f
--
You are receiving this mail because:
You are watching all bug changes.
