https://bugs.kde.org/show_bug.cgi?id=387073
Eike Hein <h...@kde.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Latest Commit| |https://commits.kde.org/kio | |/298c0e734efdd8a7b66a531959 | |e3fb5357a6495d Status|REOPENED |RESOLVED --- Comment #10 from Eike Hein <h...@kde.org> --- Git commit 298c0e734efdd8a7b66a531959e3fb5357a6495d by Eike Hein. Committed on 28/11/2017 at 10:50. Pushed by hein into branch 'master'. Fix creating a directory via KNewFileMenu+KIO::mkpath on Qt 5.9.3+ Summary: f62768d04652 in qtbase.git introduced a behavior change in QUrl causing it to reject URLs with a path of "//foo" (note the double slash) as invalid. Both KNewFileMenu and KIO::mkpath contained code following this pattern: url.path() + '/' + name This is a bad mix with forwarding slaves like kio_desktop, which translate a top-level path of / to some other URL: (desktop:)/ + / + foo = //foo This patch addresses the two instances of this by wrapping the string building in QDir::cleanPath, which I think is the shortest and most readable way to go. 2353119aae8f in kio.git (D8836) was another commit fixing fallout from this Qt change. Is unlikely this patch will be the last one. I suspect many other variations of this problem lurk about the codebase. Reviewers: dfaure, thiago, elvisangelaccio Subscribers: #frameworks Tags: #frameworks Differential Revision: https://phabricator.kde.org/D9029 M +2 -1 src/core/mkpathjob.cpp M +1 -1 src/filewidgets/knewfilemenu.cpp https://commits.kde.org/kio/298c0e734efdd8a7b66a531959e3fb5357a6495d -- You are receiving this mail because: You are watching all bug changes.