https://bugs.kde.org/show_bug.cgi?id=386983

--- Comment #16 from Ismail Donmez <ism...@i10z.com> ---
(In reply to Leslie Zhai from comment #15)
> (In reply to Ismail Donmez from comment #14)
> > Hi,
> > 
> > I don't understand
> > https://cgit.kde.org/k3b.git/commit/
> > ?id=ce5d7b139d07a875ea89fe049be852baf23f99f7 at all.
> > 
> > +    d->gcBins << d->bins;
> >      d->bins.clear();
> > 
> > and where do you use d->gcBins exactly?
> 
> https://github.com/KDE/k3b/blob/master/libk3b/core/k3bexternalbinmanager.
> cpp#L188

That's deletion, you don't actually use it at all. This fix looks very very
wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to