https://bugs.kde.org/show_bug.cgi?id=389132
Kai Uwe Broulik <k...@privat.broulik.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://commits.kde.org/pla
| |sma-workspace/e8f76cc5386d7
| |bc2878f4b72dc6e177164b3ad85
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
Version Fixed In| |5.12.0
--- Comment #6 from Kai Uwe Broulik <k...@privat.broulik.de> ---
Git commit e8f76cc5386d7bc2878f4b72dc6e177164b3ad85 by Kai Uwe Broulik.
Committed on 19/01/2018 at 09:55.
Pushed by broulik into branch 'master'.
[Notifications] Put history into a ListView
Notification uses Repeaters for everything. While this is acceptable for jobs
and notifications, of which there are few,
the history can turn into a very long list of items. Using a ListView solves
memory consumption by creating delegates only as needed.
Since regular notifications and notification history are quite entangled with
each other, I had to configure the ListView
from within the Notifications loader. To keep code changes as little as
possible, the rest of the UI is just moved into
the ListView header item.
While this is quite an invasive patch for a feature frozen version it's the
least invasive approach I could find and is quite
an important memory leak fix for an LTS.
FIXED-IN: 5.12.0
CHANGELOG: Fixed memory leak when there are a lot of items in notification
history
Differential Revision: https://phabricator.kde.org/D9978
M +1 -1
applets/notifications/package/contents/ui/NotificationDelegate.qml
M +24 -7 applets/notifications/package/contents/ui/Notifications.qml
M +17 -40 applets/notifications/package/contents/ui/main.qml
https://commits.kde.org/plasma-workspace/e8f76cc5386d7bc2878f4b72dc6e177164b3ad85
--
You are receiving this mail because:
You are watching all bug changes.
