https://bugs.kde.org/show_bug.cgi?id=385242
Peter Mühlenpfordt <de...@ukn8.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Latest Commit| |https://commits.kde.org/gwe
| |nview/5bcb8cc92d3774263fe9c
| |24cf9cbbf64da22b2f6
Resolution|--- |FIXED
--- Comment #5 from Peter Mühlenpfordt <de...@ukn8.de> ---
Git commit 5bcb8cc92d3774263fe9c24cf9cbbf64da22b2f6 by Peter Mühlenpfordt.
Committed on 22/01/2018 at 09:30.
Pushed by muhlenpfordt into branch 'master'.
Add browse mode action to action collection again
Summary:
The browse mode action with default shortcut {nav Esc} is not added to action
collection (removed in D5824) and therefore not visible/changeable in {nav
Settings > Configure Shortcuts}.
Using {nav Esc} as shortcut for e.g. Quit does not work.
This patch re-adds the browse mode action to action collection, but also checks
for `ShortcutOverride` events to handle active tool dialogs.
Test Plan:
1. Open gwenview
2. Set alternate shortcut {nav Esc} in {nav Settings -> Configure Shortcuts}
for Quit command
3. Press {nav Esc}
-> Should exit gwenview
If tool dialog (crop, red eye reduction) is active, pressing {nav Esc} should
not exit gwenview, but the tool dialog first.
Reviewers: cfeck, rkflx, ngraham
Reviewed By: rkflx, ngraham
Subscribers: ngraham
Differential Revision: https://phabricator.kde.org/D9943
M +1 -0 app/mainwindow.cpp
M +19 -13 app/viewmainpage.cpp
M +3 -1 app/viewmainpage.h
https://commits.kde.org/gwenview/5bcb8cc92d3774263fe9c24cf9cbbf64da22b2f6
--
You are receiving this mail because:
You are watching all bug changes.
