https://bugs.kde.org/show_bug.cgi?id=359909

Nate Graham <pointedst...@zoho.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |https://commits.kde.org/gwe
                   |                            |nview/338ffeee4deea6c9bf8d2
                   |                            |40593b5bc375ae50dd7
         Resolution|---                         |FIXED
   Version Fixed In|                            |18.04

--- Comment #18 from Nate Graham <pointedst...@zoho.com> ---
Git commit 338ffeee4deea6c9bf8d240593b5bc375ae50dd7 by Nathaniel Graham.
Committed on 29/01/2018 at 22:42.
Pushed by ngraham into branch 'master'.

Add a user-facing control to choose the ICC color rendering intent

Summary:
FIXED-IN: 18.04

Allow the user to choose the ICC color rendering intent, instead of hardcoding
INTENT_PERCEPTUAL

Supersedes D8763

Test Plan:
The GUI control appears and seems to work as intended.

{F5680320}

- Tested that the default value of Perceptual is used when there is no value in
~/.config/gwenviewrc
- Tested that the value gets set in ~/.config/gwenviewrc
- Tested that removing the value in ~/.config/gwenviewrc reverts the GUI
setting to Perceptual
- Tested that toggling the setting back and forth actually has an impact when
using a display with an active color profile. Here's an example:

Perceptual:
{F5677933}

Relative Colorimetric:
{F5677990}

Reviewers: DrSlony, rkflx

Reviewed By: rkflx

Subscribers: muhlenpfordt, rempt, behrmann

Differential Revision: https://phabricator.kde.org/D10076

M  +96   -3    app/advancedconfigpage.ui
M  +8    -0    app/configdialog.cpp
M  +1    -0    app/configdialog.h
M  +12   -1    lib/documentview/rasterimageview.cpp
M  +15   -0    lib/gwenviewconfig.kcfg
A  +47   -0    lib/renderingintent.h     [License: GPL]

https://commits.kde.org/gwenview/338ffeee4deea6c9bf8d240593b5bc375ae50dd7

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to