https://bugs.kde.org/show_bug.cgi?id=389033
Dmitry Kazakov <dimul...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Latest Commit|https://commits.kde.org/kri |https://commits.kde.org/kri
|ta/1a47ae24712377821994c3b0 |ta/95b2c02b0bac26cf87788a4e
|309b9437da129d73 |f31c8640635204cf
Resolution|--- |FIXED
--- Comment #10 from Dmitry Kazakov <dimul...@gmail.com> ---
Git commit 95b2c02b0bac26cf87788a4ef31c8640635204cf by Dmitry Kazakov.
Committed on 29/01/2018 at 08:27.
Pushed by dkazakov into branch 'master'.
Fix syncing pixel grid state between windows once again
Summary:
This patch extends commit1a47ae24712377821994c3b0309b9437da129d73 and
addresses the following issues:
1) The state of the menu action checkbox was not updated when the other
window changed the its state
2) There should be **no** access to KisConfig in the OpenGL rendering
loop (it is slow due to possible disk access).
3) A canvas update call should be issued right after the config changed,
otherwise the old state of the grid will be visible until one hovers
the canvas
Test Plan:
1) Open multiple Krita windows and zoom both of them to 1000%
2) Change View->Show Pixel Grid in one of the windows
3) The state on the checkbox and the canvas should automatically
update in the other window
Reviewers: #krita, scottpetrovic
Differential Revision: https://phabricator.kde.org/D10171
M +1 -0 libs/ui/KisMainWindow.cpp
M +16 -0 libs/ui/KisViewManager.cpp
M +1 -0 libs/ui/KisViewManager.h
M +9 -0 libs/ui/canvas/kis_canvas_controller.cpp
M +1 -0 libs/ui/canvas/kis_canvas_controller.h
M +5 -0 libs/ui/kis_config_notifier.cpp
M +2 -0 libs/ui/kis_config_notifier.h
M +0 -11 libs/ui/kis_paintop_box.cc
M +0 -3 libs/ui/kis_paintop_box.h
M +15 -6 libs/ui/opengl/kis_opengl_canvas2.cpp
M +1 -0 libs/ui/opengl/kis_opengl_canvas2.h
https://commits.kde.org/krita/95b2c02b0bac26cf87788a4ef31c8640635204cf
--
You are receiving this mail because:
You are watching all bug changes.
