https://bugs.kde.org/show_bug.cgi?id=384638
Nate Graham <n...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/sys
| |temsettings/6f5b6e41ec4dec6
| |af9693c3a22e5181ee850414b
Version Fixed In| |KDE Plasma 5.12.2
--- Comment #9 from Nate Graham <n...@kde.org> ---
Git commit 6f5b6e41ec4dec6af9693c3a22e5181ee850414b by Nathaniel Graham.
Committed on 19/02/2018 at 14:53.
Pushed by ngraham into branch 'Plasma/5.12'.
Improve sidebar header visibility
Summary:
FIXED-IN: KDE Plasma 5.12.2
System Settings' sidebar headers were implemented as orginary Kirigami list
items that had `enabled: false` set, which made them turn an almost unreadable
light color. This a hack; it should have used real headers. And it was the
wrong hack, as evidenced by the visual breakage.
This patch changes the hack to a different one that works much better. Ideally
we would use real Kirigami list headers here, but the current system settings
implementation seems to make this a challenge and I'm not sure it's worth it.
Willing to be proven wrong, though.
Test Plan:
Before, primary category headers, Breeze light:
{F5716438}
After, primary category headers, Breeze light:
{F5718686}
Before, sub-category headers, Breeze light:
{F5718700}
After, sub-category headers, Breeze light:
{F5718701}
Before, primary category headers, Breeze dark:
{F5716443}
After, primary category headers, Breeze dark:
{F5716442}
Before, sub-category headers, Breeze dark:
{F5718702}
After, sub-category headers, Breeze dark:
{F5718710}
Reviewers: #plasma, #kirigami, mart
Reviewed By: #plasma, #kirigami, mart
Subscribers: rkflx, plasma-devel
Tags: #plasma, #kirigami
Differential Revision: https://phabricator.kde.org/D10620
M +1 -1 sidebar/package/contents/ui/CategoriesPage.qml
M +0 -1 sidebar/package/contents/ui/SubCategoryPage.qml
https://commits.kde.org/systemsettings/6f5b6e41ec4dec6af9693c3a22e5181ee850414b
--
You are receiving this mail because:
You are watching all bug changes.
