https://bugs.kde.org/show_bug.cgi?id=363136
David Edmundson <k...@davidedmundson.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/pla
| |sma-workspace/93f0f5ee2c275
| |c3328f37675b644c1ce35f75e70
Status|UNCONFIRMED |RESOLVED
--- Comment #44 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 93f0f5ee2c275c3328f37675b644c1ce35f75e70 by David Edmundson, on
behalf of Luca Weiss.
Committed on 20/02/2018 at 12:18.
Pushed by davidedmundson into branch 'Plasma/5.12'.
Fix favicons in firefox bookmarks runner
Summary:
The favicons are located in the file favicons.sqlite file since FF 37 and the
old table was removed in FF 41 resulting in crashes because the table wasn't
found.
* Update SQL to match the tables in FF 58
* query.bindValue() needs a double colon in the string, see
https://doc.qt.io/qt-5/qsqlquery.html#prepare
* Fix intendation (tab->spaces) in one line
Test Plan:
Firefox bookmark favicons now work and don't crash Krunner and Kickoff
{F5715653}
{F5715654}
Reviewers: #plasma, broulik, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: ngraham, elvisangelaccio, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D10610
M +14 -2 runners/bookmarks/browsers/firefox.cpp
M +3 -0 runners/bookmarks/browsers/firefox.h
M +6 -5 runners/bookmarks/faviconfromblob.cpp
https://commits.kde.org/plasma-workspace/93f0f5ee2c275c3328f37675b644c1ce35f75e70
--
You are receiving this mail because:
You are watching all bug changes.
