https://bugs.kde.org/show_bug.cgi?id=363859

--- Comment #34 from Thanh Trung Dinh <dinhthanhtrung1...@gmail.com> ---
Created attachment 111187
  --> https://bugs.kde.org/attachment.cgi?id=111187&action=edit
portWebEngine_patch

Hi Maik,

I have created a new patch by shrinking the previous one. In this patch:

1/ I keep the WelcomePageViewPage class as we had discussed.

2/ I didn't modify much the backend-googlemaps-js.js. I kept the 2 js functions
used for sending message to old QWebView via status bar, so that this file is
still compatible with old QWebView. I added the console.log(...) at the end so
that there is no problem either with QWebEngineView.

3/ I understood that if all js functions had a return, we would be able to use
only runScript() (in which we would add QEventLoop) as we had used in the old
QWebView, and that would help to shrink the patch. However, all functions would
become synchronous and we might have worse performance. So, I worked around by
using a boolean variable (async) and an "if-else" to turn what we had before
(setToScript() and getFromScript()) into one function runScript() and shrink
the patch.

Besides, it seemed to me that map works much slower with QWebEngineView than
with QWebView, didn't it?

Thanh.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to