https://bugs.kde.org/show_bug.cgi?id=391884

Peter Mühlenpfordt <de...@ukn8.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |de...@ukn8.de

--- Comment #1 from Peter Mühlenpfordt <de...@ukn8.de> ---
> [huoni @ https://phabricator.kde.org/D11202#226409]
> QSizeF::transposed() simply returns a new object with width/height swapped.
> I don't see how that would help determine which combobox items were under
> which Landscape/Portrait heading.

I think you don't need to pre-categorize the settings. If height() > width() it
is portrait and vice versa. But that doesn't matter while switching the
orientation.
The corresponding setting for the other mode can be found by just searching the
transposed actual QSizeF in the combobox list.

>> IMHO a basic change/rewrite of storing and handling the combo box entries
>> stands in no relation to the benefits.
>
> Sorry not sure what you mean. Are you saying that a change/rewrite is fine
> to go ahead with regardless?

What I meant was that completely changing the combo box code ist much work and
it doesn't give that much benefit. If it could be done with a little bit of
work it's ok.  ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to