https://bugs.kde.org/show_bug.cgi?id=388663
Michael Pyne <mp...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/juk
| |/a951caf3e9dd54f56fa1a32d4d
| |c8bbbdfc269252
Status|UNCONFIRMED |RESOLVED
Version Fixed In| |18.04
--- Comment #6 from Michael Pyne <mp...@kde.org> ---
Git commit a951caf3e9dd54f56fa1a32d4dc8bbbdfc269252 by Michael Pyne.
Committed on 25/03/2018 at 19:44.
Pushed by mpyne into branch 'master'.
Simplify shutdown handling.
JuK would fail to shutdown properly under Plasma 5 when the system tray
was disabled and you used the 'X' from the window manager title bar to
try to close JuK. May have failed under other WMs or desktops as well,
I haven't tested that.
The shutdown code hasn't been reworked since KDE 3 times and for all I
know I introduced this bug with the setQuitOnLastWindowClosed setting in
main.cpp years ago and never realized.
But this way, any way you destroy the main application class (JuK), you
end up shutting down. Continuing to use setQuitOnLastWindowClosed
appears to be necessary since Qt will remove the queued quit signal to
qApp once JuK is destructed and I don't trust running qApp->quit within
the JuK dtor itself.
Hopefully this fixes a crash-on-quit bug, but if not just reopen and
I'll figure it out somehow...
FIXED-IN:18.04
M +35 -32 juk.cpp
M +0 -1 juk.h
M +0 -6 main.cpp
https://commits.kde.org/juk/a951caf3e9dd54f56fa1a32d4dc8bbbdfc269252
--
You are receiving this mail because:
You are watching all bug changes.
