https://bugs.kde.org/show_bug.cgi?id=359871

--- Comment #11 from Ivo Raisr <iv...@ivosh.net> ---
Thank you for the patch covering Linux.

I have only three minor comments:
- Why assert ARG7 == 0 in pselect6 wrapper? On some architectures arg7 would be
on stack,
  containing some random values. On others arg7 could refer to a register
containing garbage
  as well.
- The first argument (cost center) to VG_(malloc)() should reflect the
function/wrapper name. On Solaris it was pollsys, on Linux it is pselect6 or
ppoll.
- Please use 'vgopts: -q' in pselect_alarm.vgtest so the stack trace is not a
part of stderr.exp. It differs between operating systems. If you insist on
having there some stack information then for example a filter can be used to
filter anything before main().

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to