https://bugs.kde.org/show_bug.cgi?id=345307
--- Comment #13 from Mark Wielaard <m...@redhat.com> --- (In reply to Ivo Raisr from comment #11) > Yes, it can be done with just one FREERES_DONE hook. > But it means we need to pass argument(s) to it (which __freeres functions to > call) and this will involve some extra code for all supported architectures. > See invoker_invoke_gdbserver() in vgdb-invoker-ptrace.c and > setup_stack_frame() in vgdb-invoker-solaris.c for some inspiration. The LIBC/CXX_FREERES_DONE user requests are only handled in scheduler.c os_client_request (). They are called from the hooks and only set VgSrc_ExitThread. I must be missing something, but I cannot see how that is related to invoker_invoke_gdbserver or setup_stack_frame. Or how those currently make a distinction between VG_USERREQ__LIBC_FREERES_DONE and VG_USERREQ__CXX_FREERES_DONE. Could you explain where/how which arguments need to be passed to which function if there was just one VG_USERREQ__FREERES_DONE called from both freeres and cxx_freeres in vg_preloaded.c? I don't want there to be more (complicated) code, I just don't understand why it isn't simpler to have only one kind of FREERES user request. -- You are receiving this mail because: You are watching all bug changes.
