https://bugs.kde.org/show_bug.cgi?id=393644
Kurt Hindenburg <kurt.hindenb...@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CONFIRMED |RESOLVED Resolution|--- |FIXED Latest Commit| |https://commits.kde.org/kon | |sole/bdd98f8561ec92098794e4 | |11517f630c87a1dc02 --- Comment #6 from Kurt Hindenburg <kurt.hindenb...@gmail.com> --- Git commit bdd98f8561ec92098794e411517f630c87a1dc02 by Kurt Hindenburg, on behalf of Mariusz Glebocki. Committed on 03/05/2018 at 00:46. Pushed by hindenburg into branch 'master'. Restore Bi-Directional text support Summary: Fix regression introduced by commit a565bc9 (Clip character drawing to its own cell). When the first character in a text fragment is classified as RTL, rest of the fragment is also considered to be RTL and is passed to `drawText()` as one string. The rendering is not perfect (especially when RTL and LTR characters are mixed), but it works as before. {F5830191} Test Plan: * Display example sentences using a program which prints text directly to terminal (e.g. `echo`, `cat`): ``` حروف به هم پیوسته کِیدیئی (به انگلیسی: KDE) پروژهای برای توسعه یک میزکار آزاد و متن باز است. ``` * Display the sentences in Konsole built before commit a565bc97337a3bfc3a027f46aa2dec3e9a6f8618 * Compare visually Reviewers: #konsole, sassanh, hindenburg Reviewed By: #konsole, sassanh, hindenburg Subscribers: hindenburg, #konsole Tags: #konsole Differential Revision: https://phabricator.kde.org/D12655 M +28 -2 src/TerminalDisplay.cpp https://commits.kde.org/konsole/bdd98f8561ec92098794e411517f630c87a1dc02 -- You are receiving this mail because: You are watching all bug changes.