https://bugs.kde.org/show_bug.cgi?id=394842

            Bug ID: 394842
           Summary: Animation timeline's "Remove Frames and Pull" works
                    inconsistently when the frame after the currently
                    selected frame is null/empty/hold.
           Product: krita
           Version: git master
          Platform: Compiled Sources
                OS: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: NOR
         Component: Animation
          Assignee: krita-bugs-n...@kde.org
          Reporter: emmetoneill....@gmail.com
  Target Milestone: ---

Animation timeline's "Remove Frames and Pull" works inconsistently when the
frame after the currently selected frame is null/empty/hold.

This is a minor bug with the "Remove Frames and Pull" action from the Animation
Timeline's right-click context menu. 

This feature seems to work as expected when the frame *after* the selected
frame contains a keyframe (including blank keyframes) - the currently selected
frame is removed and all of the following frames are shifted back/left.

However, when the frame immediately *after* the selected frame is
null/empty/hold, there is a bug where the selected frame is not removed, even
though all subsequent frames are still shifted back. As such, the
last/rightmost frame in the timeline can never be removed with "Remove Frames
and Pull".

---

Here's how to test this:

You can test this by creating two adjacent frames. Draw an "A" on the first one
and a "B" on the second. If you select the first (A) and try "Remove Frames and
Pull" you'll see the expected behavior - the frame with the "A" will be deleted
and the frame with the "B" will shift back to take its place. However, if you
select the second frame (B) and try "Remove Frames and Pull" you'll see that
neither frame is deleted, although the subsequent frames will still be shifted
back.

---

This is probably a small error with indices or early-returning in either
KisTimeBasedItemModel::removeFramesAndOffset or
KisTimeBasedItemModel::createOffsetFramesCommand functions.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to