https://bugs.kde.org/show_bug.cgi?id=395375

Boudewijn Rempt <b...@valdyas.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://commits.kde.org/kri |https://commits.kde.org/kri
                   |ta/eadfec3dd43ecd72c3080a87 |ta/befdf29e08828b85c2e30e30
                   |96711477089511b8            |fae6d188a9d0805c

--- Comment #9 from Boudewijn Rempt <b...@valdyas.org> ---
Git commit befdf29e08828b85c2e30e30fae6d188a9d0805c by Boudewijn Rempt, on
behalf of Jonathan Liu.
Committed on 25/06/2018 at 08:14.
Pushed by rempt into branch 'krita/4.1'.

Do not scroll pop-up palette when setting document offset

Summary:
QWidget::scroll(int dx, int dy) will scroll the widget including its
children. Since KisPopupPalette is a child of KisQPainterCanvas when
using the QPainter-based canvas we want to scroll only the widget
and not its children by calling QWidget::scroll(int dx, int dy,
const QRect &r) instead.

Test Plan:
1. Click Settings > Configure Krita > Display
2. Uncheck "Canvas Graphics Acceleration" and click OK
3. File > New to create new document
4. Click "Freehand Brush Tool"
5. Right-click on canvas, rotate using wheel. The popup should not move.
6. Right-click on canvas, reset rotation by clicking at top circle of wheel.
The popup should not move.
7. Right-click on canvas, zoom using zoom slider. The popup should not move.
8. Right-click on canvas, reset zoom to 100% by clicking "100%" button. The
popup should not move,.

Reviewers: #krita, dkazakov

Reviewed By: #krita, dkazakov

Subscribers: dkazakov, #krita

Tags: #krita

Differential Revision: https://phabricator.kde.org/D13703

M  +1    -1    libs/flake/KoCanvasControllerWidget.cpp
M  +1    -1    libs/image/generator/kis_generator_layer.cpp

https://commits.kde.org/krita/befdf29e08828b85c2e30e30fae6d188a9d0805c

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to