https://bugs.kde.org/show_bug.cgi?id=396102
David Edmundson <k...@davidedmundson.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Latest Commit| |https://commits.kde.org/kac
| |tivities-stats/75d6103df944
| |c02a7ff4f85f2d2e565d3fdc40b
| |c
Resolution|--- |FIXED
--- Comment #4 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 75d6103df944c02a7ff4f85f2d2e565d3fdc40bc by David Edmundson.
Committed on 03/07/2018 at 14:22.
Pushed by davidedmundson into branch 'master'.
Fix ResultModel item moving
Summary:
The intention of this code is to find the new insertion index in the
cache where a resource should now be by counting number of items in the
cache with a higher score/update time/whatever.
FixedItems comparison compares two resources by string IDs, checking if
they're user pinned. If so they go on top.
In FullOrdering if neither compared item is pinned it also compares literal
resourceId. Useful if you have no other sorting tests and want to
maintain order, not useful if we want to contintue to compare the score
as in 50% case of the cases we'll fail our lessThan early.
Test Plan:
Ran test app
Changed some scores by clicking in kickoff
They moved appropriately instead of being moved all over the place
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D13866
M +1 -1 src/resultmodel.cpp
https://commits.kde.org/kactivities-stats/75d6103df944c02a7ff4f85f2d2e565d3fdc40bc
--
You are receiving this mail because:
You are watching all bug changes.
