https://bugs.kde.org/show_bug.cgi?id=365917
Michael Pyne <mp...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mp...@kde.org
--- Comment #4 from Michael Pyne <mp...@kde.org> ---
The patch as attached looks stylistically correct to me, using a CMake check to
generate a config.h file that would then be used for the include guard. That's
also how I'd do it, and I wouldn't have even bothered to fix the .gitignore
myself.
However the patch wouldn't have worked directly (the fix to FindLibIntl.cmake
uses "HAVE_..." while the code checks for "HAS_..."). Also I'd use a namespaced
include guard in config.h (e.g. "#ifndef KF5_KI18N_CONFIG_H ..." instead of
"#ifndef CONFIG_H"), but that's more about residual trauma from --enable-final
builds back in the day.
Since we've already got a soft +1 on this patch already I'll go ahead and
commit the corrected patch in the next day or two if there's no objections from
here.
P.S. I've previously built all of KF5 on Alpine Linux (also using musl libc)
while testing Docker, but I think that had worked because I had also installed
GNU libintl, presumably that overrides the musl libintl if both exist?
--
You are receiving this mail because:
You are watching all bug changes.
