https://bugs.kde.org/show_bug.cgi?id=397650
TallFurryMan <eric.dejouha...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |eric.dejouha...@gmail.com
--- Comment #1 from TallFurryMan <eric.dejouha...@gmail.com> ---
Thanks for reporting this. First, do you think could seqTotalCount be dropped
completely and replaced with activeJob->getCount() ? Variable "seqTotalCount"
is a shortcut counter that is difficult to track.
If the frame type is FLAT, the code should probably be self-contained in terms
of calibration. It should prevent the increase of the capture count if the ADU
tolerance is not met, and only that. Instead it seems to rely on isPreview
which has multiple meanings and can be set outside of the calibration feature.
Besides, I also see that the ADU check is done at two locations, when the ADU
value is saturated, and when the new exposure is calculated.
There are also a few forum threads raising issues with the stability of the ADU
calculation. I believe that the ADU polyfit algorithm should limit the number
of samples it is working with to the N latest ones. This is even more true when
running dawn/dusk flats, for which older ADUs quickly become irrelevant. But
that is another topic perhaps.
--
You are receiving this mail because:
You are watching all bug changes.
