https://bugs.kde.org/show_bug.cgi?id=360140
Thomas Lübking <thomas.luebk...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |CONFIRMED
Ever confirmed|0 |1
Summary|Fall apart effect not |Deleted uses the direct
|working |window type, but doesn't
| |perform hack resolutions
Component|effects-window-management |core
--- Comment #10 from Thomas Lübking <thomas.luebk...@gmail.com> ---
The bug goes a tiny little bit beyond the effect ;-)
commit fec2b6310282d9ca11d21b5ea66e2f3243ef1825
Author: Martin Gräßlin <mgraess...@kde.org>
Date: Wed Mar 4 08:26:57 2015 +0100
Copy NET::WindowType to Deleted
This was suggested to be done in a comment. The existing code might
have returned incorrect results for Client. So let's get the primary
window type and use that one.
I think the patch is wrong and terribly misgot the comment - the idea was
likely to copy over the *indirect* type, ie. Normal if it's unknown and not a
transient etc. (and urxvt doesn't seem to support NETWM)
This fixes it:
--------------------
diff --git a/deleted.cpp b/deleted.cpp
index 5e0225f..e784bd1 100644
--- a/deleted.cpp
+++ b/deleted.cpp
@@ -84,7 +84,7 @@ void Deleted::copyToDeleted(Toplevel* c)
m_layer = c->layer();
m_frame = c->frameId();
m_opacity = c->opacity();
- m_type = c->windowType(true);
+ m_type = c->windowType();
m_windowRole = c->windowRole();
if (WinInfo* cinfo = dynamic_cast< WinInfo* >(info))
cinfo->disable()
--
You are receiving this mail because:
You are watching all bug changes.
