https://bugs.kde.org/show_bug.cgi?id=385298
Amish Naidu <amh...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/kde
| |velop/cef296113612ae72e561a
| |1300d0622a46fcf1906
--- Comment #3 from Amish Naidu <amh...@gmail.com> ---
Git commit cef296113612ae72e561a1300d0622a46fcf1906 by Amish Naidu.
Committed on 28/09/2018 at 14:58.
Pushed by anaidu into branch '5.3'.
Fix removal of external scripts
Summary:
Previously, deleting a script which is in the middle of the config would
invalidate indices
of the scripts that come after it in the config, this would mean deleting
anything later deletes the wrong script.
The config labels are now stored in the model itself and is no longer based on
just the index,
but on the name of the script. Thus, deleting/updating one script does not
interfere with the
other scripts.
Test Plan:
* Before applying the patch:
- Delete "Google Selection"
- Restart
- Delete "Quick Compile"
- Restart and check list of external scripts
* Apply the patch and repeat.
Reviewers: #kdevelop, flherne
Reviewed By: #kdevelop, flherne
Subscribers: flherne, kdevelop-devel
Tags: #kdevelop
Differential Revision: https://phabricator.kde.org/D15743
M +11 -0 plugins/externalscript/externalscriptitem.cpp
M +11 -0 plugins/externalscript/externalscriptitem.h
M +34 -9 plugins/externalscript/externalscriptplugin.cpp
M +12 -2 plugins/externalscript/externalscriptplugin.h
https://commits.kde.org/kdevelop/cef296113612ae72e561a1300d0622a46fcf1906
--
You are receiving this mail because:
You are watching all bug changes.
