https://bugs.kde.org/show_bug.cgi?id=400083

David Edmundson <k...@davidedmundson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |https://commits.kde.org/kwi
                   |                            |n/110fa039cbf8e7f414d8db7d4
                   |                            |a68102d8fd9420f
         Resolution|---                         |FIXED

--- Comment #7 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 110fa039cbf8e7f414d8db7d4a68102d8fd9420f by David Edmundson.
Committed on 26/10/2018 at 11:13.
Pushed by davidedmundson into branch 'master'.

Use consistent size icon in OSD

Summary:
The OSD's icon is based on the implicitSize of the IconItem.

For most icons this will be a hardcoded value from
KIconLoader::global()->currentSize

However, since bc33f0470d4d6bcbf30475f85b36705e8a99528b in
plasma-framework we sometimes return that value, sometimes will return the
source size of the underlying image depending on internal paths of how
the icon is loaded and whether it was in the plasma theme or not.

This patch overrides the implicitWidth given to the layout to be the
standard icon size.

Test Plan:
Loaded the force kill window OSD.
Icon still looked the same size on breeze.

I didn't reproduce the issue in the bug

Reviewers: #kwin, graesslin

Reviewed By: #kwin, graesslin

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D16432

M  +2    -2    qml/onscreennotification/plasma/main.qml

https://commits.kde.org/kwin/110fa039cbf8e7f414d8db7d4a68102d8fd9420f

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to