https://bugs.kde.org/show_bug.cgi?id=400170
Vlad Zagorodniy <vladz...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Version Fixed In| |5.14.4
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/kwi
| |n/ad28da84e78c7eb7ff1e608c4
| |819707b2142daea
Status|CONFIRMED |RESOLVED
--- Comment #16 from Vlad Zagorodniy <vladz...@gmail.com> ---
Git commit ad28da84e78c7eb7ff1e608c4819707b2142daea by Vlad Zagorodniy.
Committed on 07/11/2018 at 17:22.
Pushed by vladz into branch 'Plasma/5.14'.
[effects/slidingpopups] Don't crash when sliding virtual desktops
Summary:
If you switch virtual desktops while krunner is sliding in, then
depending on whether your distro strips assert statements away,
KWin can crash.
The reason why it crashes is the sliding popups effect tries to unref
deleted windows that it hasn't referenced before (if there is an active
full screen effect, then popups won't be slided out, which in its turn
means that we won't reference deleted windows). So, in the end, the
refcount of those windows can be -1. That triggers an assert statement
in the destructor of the Deleted class, which checks whether the
refcount is equal to 0.
Popups are not slided while there is an active full screen effect because
we don't know what the full screen effect does.
This patch adjusts the sliding popups effect so it stops all active
animations when user switches virtual desktops or when a full screen
effect kicks in. We need to do that so the effect won't try to
unreference windows in postPaintWindow.
Visually, it doesn't look quite nice, but for now that's good enough.
A proper fix would be more complex: we would need to make sure that
full screen effects ignore sliding popups (and also maybe docks) and
perform some input redirection.
FIXED-IN: 5.14.4
Test Plan: I'm not able anymore to reproduce bug 400170.
Reviewers: #kwin, graesslin
Reviewed By: #kwin, graesslin
Subscribers: davidedmundson, graesslin, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D16731
M +22 -0 effects/slidingpopups/slidingpopups.cpp
M +3 -3 effects/slidingpopups/slidingpopups.h
https://commits.kde.org/kwin/ad28da84e78c7eb7ff1e608c4819707b2142daea
--
You are receiving this mail because:
You are watching all bug changes.
