https://bugs.kde.org/show_bug.cgi?id=360035

--- Comment #11 from Carl Love <c...@us.ibm.com> ---
Created attachment 98192
  --> https://bugs.kde.org/attachment.cgi?id=98192&action=edit
Updated patch to fix BCD add/subtract vbit error

The previous patch broke the vbit-test test.  

The issue is the Iop_BCDAdd and Iop_BCDSub pass the ps value down to the
instruction generation code.  The issue is the ps value is a constant passed in
the triop() function call in  function dis_av_bcd ( ),
VEX/priv/guest_ppc_toIR.c.  The vbit-test assumes that the arguments of the
triop() are expressions so it can set the vbits for each of the arguments. 
However, the ps value is a constant so the test couldn't set the vbits for ps.  

The implementation of the BCD add and subtract instructions was changed to not
pass the ps value, the vbit-test was updated to remove some no longer needed
comments and code for the ps argument.  The memcheck code was updated to handle
the new implementation of the BCD add and subtract instructions.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to