https://bugs.kde.org/show_bug.cgi?id=400980

Vlad Zagorodniy <vladz...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/kwi
                   |                            |n/80da18a143f1b57751e77f957
                   |                            |4212ff60ff14950
             Status|REPORTED                    |RESOLVED
         Resolution|---                         |FIXED
   Version Fixed In|                            |5.15.0

--- Comment #3 from Vlad Zagorodniy <vladz...@gmail.com> ---
Git commit 80da18a143f1b57751e77f9574212ff60ff14950 by Vlad Zagorodniy.
Committed on 15/11/2018 at 20:08.
Pushed by vladz into branch 'master'.

[decorations] Emit DecorationSettings::fontChanged signal

Summary:
No one emits DecorationSettings::fontChanged signal, so if you change
the window title font, then titlebars might look differently after reboot.

Currently, there are two places where we can emit that signal:
- in KDecoration library itself;
- and in KWin.

Because we would need to listen for a Plasma specific D-Bus signal, the
latter option is preferable.

Surprisingly, KWin's implementation of DecorationSettingsPrivate already
reacts to refreshFonts D-Bus signal (even though indirectly), so all
what we have to do is get the current window title font in
SettingsImpl::readSettings, and if it's different from the previous one,
emit DecorationSettings::fontChanged signal.
FIXED-IN: 5.15.0

Test Plan:
* Increased the size of the window title font, titlebars got bigger;
* Decreased the font size, titlebars got smaller.

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D16908

M  +7    -0    decorations/settings.cpp
M  +4    -0    decorations/settings.h

https://commits.kde.org/kwin/80da18a143f1b57751e77f9574212ff60ff14950

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to